-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FAD/Ubiquinone Duplicates #613
Fix FAD/Ubiquinone Duplicates #613
Conversation
… but remove the FAD-dependent version of the SDH reaction
I have no idea how to interpret the error message generated by the YAML validation check (I figured out the issue by manually inspecting each of the changes I made, which is not unreasonable, but it would've been nice if the error message had given me any hints about what I should've been looking for) |
I am a little bit afraid of this kind of changes. In case reviewers merge this PR, I tag this PR for draft first. Discussions will come later in the Issue page. |
nope I still don't know why the YAML validation test is failing |
I'll have a look, perhaps I can spot something |
First thing I'm trying is to run the validation locally on this PR with
This returns the same error
It seems the other PRs are passing this test, so a more in-depth look is required. Sorry I cannot do more at the moment, but I'll try to get back to this tomorrow. |
Aha the problem is that |
@Devlin-Moyer I'm glad you figured out the unused gene. |
@Devlin-Moyer please merge |
Main improvements in this PR:
As discussed in #607:
MAR02035
for being a duplicate ofMAR03121
MAR03211
for being a duplicate ofMAR03212
MAR03751
for being a duplicate ofMAR03752
MAR03783
for being a duplicate ofMAR03784
MAR04242
for being a duplicate ofMAR04243
MAR03769
for being a duplicate ofMAR03770
MAR03838
for being a duplicate ofMAR08611
MAR02366
for being a duplicate ofMAR03136
MAR02367
for being a duplicate ofMAR03135
MAR02370
for being a duplicate ofMAR03128
MAR02372
for being a duplicate ofMAR03156
MAR02369
for being a duplicate ofMAR03149
MAR02373
for being a duplicate ofMAR03142
MAR00483
for being a duplicate ofMAR00482
/MAR00449
/MAR01169
MAR08743
for being a duplicate ofMAR04652
I hereby confirm that I have:
develop
as a target branch